| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove PQsendQuery support in pipeline mode |
| Date: | 2022-09-23 16:24:34 |
| Message-ID: | E1oblTe-001g67-68@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove PQsendQuery support in pipeline mode
The extended query protocol implementation I added in commit
acb7e4eb6b1c has bugs when used in pipeline mode. Rather than spend
more time trying to fix it, remove that code and make the function rely
on simple query protocol only, meaning it can no longer be used in
pipeline mode.
Users can easily change their applications to use PQsendQueryParams
instead. We leave PQsendQuery in place for Postgres 14, just in case
somebody is using it and has not hit the mentioned bugs; but we should
recommend that it not be used.
Backpatch to 15.
Per bug report from Gabriele Varrazzo.
Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0032a5456708811ca95bd80a538f4fb72ad0dd20
Modified Files
--------------
doc/src/sgml/libpq.sgml | 9 +-
src/interfaces/libpq/fe-exec.c | 117 +++++------------------
src/interfaces/libpq/fe-protocol3.c | 18 +---
src/test/modules/libpq_pipeline/libpq_pipeline.c | 12 +++
4 files changed, 41 insertions(+), 115 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-23 18:00:09 | pgsql: Doc: update v15 release notes through today. |
| Previous Message | Alvaro Herrera | 2022-09-23 16:12:42 | pgsql: Stop using PQsendQuery in libpq_pipeline |