From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Don't hardcode tmp_check/ as test directory for tap tests |
Date: | 2022-09-20 01:28:11 |
Message-ID: | E1oaS3X-0017xN-1w@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Don't hardcode tmp_check/ as test directory for tap tests
This is motivated by the meson patchset, which wants to put the log / data for
tests in a different place than the autoconf build. Right now log files for
tap tests have to be inside $TESTDIR/tmp_check, whereas log files for
pg_regress/isolationtester are outside of tmp_check. This change doesn't fix
the latter, but is a prerequisite.
The only test that needs adjustment is 010_tab_completion.pl, as it hardcoded
the tmp_check/ directory. Instead create a dedicated directory for the test
files. It's also a bit cleaner independently, because it doesn't intermingle
the test files with more important things like the log/ directory.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/1131990.1660661896@sss.pgh.pa.us
Discussion: https://postgr.es/m/d861493c-ed20-c251-7a89-7924f5197341@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bb54bf22900f76dab6899594d47f55d62e912143
Modified Files
--------------
src/Makefile.global.in | 6 +++---
src/bin/psql/t/010_tab_completion.pl | 33 +++++++++++++++++----------------
src/test/perl/PostgreSQL/Test/Utils.pm | 2 +-
src/tools/msvc/vcregress.pl | 2 +-
4 files changed, 22 insertions(+), 21 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2022-09-20 01:31:22 | Re: pg_upgrade test failure |
Previous Message | Michael Paquier | 2022-09-20 01:25:41 | Re: pg_upgrade test failure |