pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.
Date: 2022-09-02 18:55:04
Message-ID: E1oUBol-0017c3-JB@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix oversight in recent MULTIEXPR_SUBLINK fix.

Commits 3f7323cbb et al missed the possibility that the Params
they are looking for could be buried under implicit coercions,
as well as other stuff that processIndirection() could add to
the original targetlist entry. Copy the code in ruleutils.c
that deals with such cases. (I thought about refactoring so
that there's just one copy; but seeing that we only need this
in old back branches, it seems not worth the trouble.)

Per off-list report from Andre Lin. As before, only v10-v13
need the patch.

Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/56dc4424472c2fa27f8822efe09d18c6935fe2a3

Modified Files
--------------
src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++---
src/test/regress/expected/inherit.out | 24 ++++++++++----------
src/test/regress/sql/inherit.sql | 10 ++++-----
3 files changed, 54 insertions(+), 20 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-09-02 21:02:01 pgsql: Fix planner to consider matches to boolean columns in extension
Previous Message Daniel Gustafsson 2022-09-02 18:51:06 pgsql: Remove unused code from sepgsql