From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking |
Date: | 2022-08-05 16:04:43 |
Message-ID: | E1oJzoZ-000RpJ-2b@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.
Add a test that tickles the case, as branch testing technology allows.
This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.
Author: 王海洋 (Haiyang Wang) <wanghaiyang(dot)001(at)bytedance(dot)com>
Reviewed-by: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e44dae07f931383151e2eb34ed9b4cbf4bf14482
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 7 ++-
src/backend/access/brin/brin_xlog.c | 6 +++
src/test/modules/brin/Makefile | 2 +-
src/test/modules/brin/t/02_wal_consistency.pl | 75 +++++++++++++++++++++++++++
4 files changed, 88 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2022-08-05 16:10:43 | Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking |
Previous Message | Noah Misch | 2022-08-05 15:33:07 | pgsql: Add HINT for restartpoint race with KeepFileRestoredFromArchive( |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2022-08-05 16:10:43 | Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking |
Previous Message | Robert Haas | 2022-08-05 15:55:33 | Re: A proposal for shared memory based backup infrastructure |