pgsql: Remove dead pread and pwrite replacement code.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove dead pread and pwrite replacement code.
Date: 2022-08-04 21:59:42
Message-ID: E1oJisY-000Kn0-16@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dead pread and pwrite replacement code.

pread() and pwrite() are in SUSv2, and all targeted Unix systems have
them.

Previously, we defined pg_pread and pg_pwrite to emulate these function
with lseek() on old Unixen. The names with a pg_ prefix were a reminder
of a portability hazard: they might change the current file position.
That hazard is gone, so we can drop the prefixes.

Since the remaining replacement code is Windows-only, move it into
src/port/win32p{read,write}.c, and move the declarations into
src/include/port/win32_port.h.

No need for vestigial HAVE_PREAD, HAVE_PWRITE macros as they were only
used for declarations in port.h which have now moved into win32_port.h.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Greg Stark <stark(at)mit(dot)edu>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cf112c122060568aa06efe4e6e6fb9b2dd4f1090

Modified Files
--------------
configure | 38 ++++++-------------
configure.ac | 4 +-
contrib/pg_stat_statements/pg_stat_statements.c | 4 +-
src/backend/access/heap/rewriteheap.c | 2 +-
src/backend/access/transam/slru.c | 4 +-
src/backend/access/transam/xlog.c | 4 +-
src/backend/access/transam/xlogreader.c | 2 +-
src/backend/access/transam/xlogrecovery.c | 2 +-
src/backend/replication/basebackup.c | 2 +-
src/backend/replication/walreceiver.c | 2 +-
src/backend/storage/file/fd.c | 4 +-
src/backend/utils/init/miscinit.c | 2 +-
src/bin/pg_test_fsync/pg_test_fsync.c | 50 ++++++++++++-------------
src/include/access/xlogreader.h | 4 +-
src/include/pg_config.h.in | 6 ---
src/include/port.h | 19 ----------
src/include/port/win32_port.h | 6 +++
src/port/preadv.c | 4 +-
src/port/pwritev.c | 4 +-
src/port/{pread.c => win32pread.c} | 22 ++---------
src/port/{pwrite.c => win32pwrite.c} | 22 ++---------
src/tools/msvc/Mkvcbuild.pm | 4 +-
src/tools/msvc/Solution.pm | 2 -
23 files changed, 76 insertions(+), 137 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-08-04 22:14:27 pgsql: Fix failure to set correct operator in window run condition
Previous Message Robert Haas 2022-08-04 19:30:33 pgsql: Revert recent changes to 002_pg_upgrade.pl.