pgsql: Remove configure probe for link.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove configure probe for link.
Date: 2022-08-04 21:59:42
Message-ID: E1oJisX-000Kmq-Vs@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove configure probe for link.

link() is in SUSv2 and all targeted Unix systems have it. We have
replacement code for Windows that doesn't require a configure probe.
Since only Windows needs it, rename src/port/link.c to win32link.c like
other similar things.

There is no need for a vestigial HAVE_LINK macro, because we expect all
Unix and, with our replacement function, Windows systems to have it, so
we didn't have any tests around link() usage.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5963c9a154bd5590a7ea48826d9bd72c9324e071

Modified Files
--------------
configure | 19 ++++++-------------
configure.ac | 2 +-
src/include/pg_config.h.in | 3 ---
src/include/port.h | 3 ++-
src/port/{link.c => win32link.c} | 8 ++------
src/tools/msvc/Mkvcbuild.pm | 6 ++++--
src/tools/msvc/Solution.pm | 1 -
7 files changed, 15 insertions(+), 27 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-08-04 22:14:27 pgsql: Fix failure to set correct operator in window run condition
Previous Message Robert Haas 2022-08-04 19:30:33 pgsql: Revert recent changes to 002_pg_upgrade.pl.