pgsql: Remove configure probe and related tests for getrlimit.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove configure probe and related tests for getrlimit.
Date: 2022-08-04 21:59:42
Message-ID: E1oJisX-000Kmf-U0@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove configure probe and related tests for getrlimit.

getrlimit() is in SUSv2 and all targeted systems have it.

Windows doesn't have it. We could just use #ifndef WIN32, but for a
little more explanation about why we're making things conditional, let's
retain the HAVE_GETRLIMIT macro. It's defined in port.h for Unix systems.

On systems that have it, it's not necessary to test for RLIMIT_CORE,
RLIMIT_STACK or RLIMIT_NOFILE macros, since SUSv2 requires those and all
targeted systems have them. Also remove references to a pre-historic
alternative spelling of RLIMIT_NOFILE, and coding that seemed to believe
that Cygwin didn't have it.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bdb657edd6db1e471437d62f4642674a801ef32c

Modified Files
--------------
configure | 2 +-
configure.ac | 1 -
src/backend/storage/file/fd.c | 4 ----
src/backend/tcop/postgres.c | 8 ++------
src/bin/pg_ctl/pg_ctl.c | 8 ++++----
src/bin/pgbench/pgbench.c | 4 ----
src/include/pg_config.h.in | 3 ---
src/include/port.h | 8 ++++++++
src/test/regress/pg_regress.c | 4 ++--
src/tools/msvc/Solution.pm | 1 -
10 files changed, 17 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-08-04 22:14:27 pgsql: Fix failure to set correct operator in window run condition
Previous Message Robert Haas 2022-08-04 19:30:33 pgsql: Revert recent changes to 002_pg_upgrade.pl.