pgsql: Reduce test runtime of src/test/modules/snapshot_too_old.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reduce test runtime of src/test/modules/snapshot_too_old.
Date: 2022-08-03 15:15:13
Message-ID: E1oJG5Z-0008pd-3a@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reduce test runtime of src/test/modules/snapshot_too_old.

The sto_using_cursor and sto_using_select tests were coded to exercise
every permutation of their test steps, but AFAICS there is no value in
exercising more than one. This matters because each permutation costs
about six seconds, thanks to the "pg_sleep(6)". Perhaps we could
reduce that, but the useless permutations seem worth getting rid of
in any case. (Note that sto_using_hash_index got it right already.)

While here, clean up some other sloppiness such as an unused table.

This doesn't make too much difference in interactive testing, since the
wasted time is typically masked by parallelization with other tests.
However, the buildfarm runs this as a serial step, which means we can
expect to shave ~40 seconds from every buildfarm run. That makes it
worth back-patching.

Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e94c52fca6e10f227d5635112eb7f11f767f7a8d

Modified Files
--------------
.../snapshot_too_old/expected/sto_using_cursor.out | 76 ----------------------
.../snapshot_too_old/expected/sto_using_select.out | 55 ----------------
.../snapshot_too_old/specs/sto_using_cursor.spec | 7 +-
.../snapshot_too_old/specs/sto_using_select.spec | 7 +-
4 files changed, 8 insertions(+), 137 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2022-08-03 16:29:22 pgsql: Add another old commit to git-blame-ignore-revs.
Previous Message Tom Lane 2022-08-03 14:02:23 Re: pgsql: Add wait_for_subscription_sync for TAP tests.