pgsql: In transformRowExpr(), check for too many columns in the row.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: In transformRowExpr(), check for too many columns in the row.
Date: 2022-07-29 17:31:31
Message-ID: E1oHTpi-001oKv-I3@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In transformRowExpr(), check for too many columns in the row.

A RowExpr with more than MaxTupleAttributeNumber columns would fail at
execution anyway, since we cannot form a tuple datum with more than that
many columns. While heap_form_tuple() has a check for too many columns,
it emerges that there are some intermediate bits of code that don't
check and can be driven to failure with sufficiently many columns.
Checking this at parse time seems like the most appropriate place to
install a defense, since we already check SELECT list length there.

While at it, make the SELECT-list-length error use the same errcode
(TOO_MANY_COLUMNS) as heap_form_tuple does, rather than the generic
PROGRAM_LIMIT_EXCEEDED.

Per bug #17561 from Egor Chindyaskin. The given test case crashes
in all supported branches (and probably a lot further back),
so patch all.

Discussion: https://postgr.es/m/17561-80350151b9ad2ad4@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd96d14d950f2b1d19b5cb3b8e5a7d4d2b3fa161

Modified Files
--------------
src/backend/parser/parse_expr.c | 8 ++++++++
src/backend/parser/parse_node.c | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-29 19:38:58 pgsql: Support pg_read_[binary_]file (filename, missing_ok).
Previous Message Robert Haas 2022-07-29 15:27:33 pgsql: Fix mistake in bbe08b8869bd29d587f24ef18eb45c7d4d14afca.