pgsql: Make Windows 10 the minimal runtime requirement for WIN32

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make Windows 10 the minimal runtime requirement for WIN32
Date: 2022-07-07 04:26:36
Message-ID: E1o9J62-001aJP-P3@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make Windows 10 the minimal runtime requirement for WIN32

This commit bumps the runtime value of _WIN32_WINNT to be 0x0A00 for any
builds on Windows. Hence, this makes Windows 10 the minimal requirement
when running PostgreSQL under WIN32, be it for builds of Cygwin, MinGW
or Visual Studio.

The previous minimal runtime version was either Windows Vista when
building with at least Visual Studio 2015 or Windows XP for the rest.

Windows 10 is the most modern version supported by Microsoft, and per
discussion, as we don't have buildfarm members that run older versions
anymore, this is the minimal supported version that suits better for our
needs. This will actually make easier the development of some patches,
two being async I/O and large page handling by avoiding a lot of
compatibility gotchas, on platforms that have most likely few users
anyway.

It is possible to remove MIN_WINNT in win32.h and the macros
IsWindowsXXXOrGreater() that were used in the code at runtime to check
which version of Windows was getting used. The change in pg_locale.c
comes from Juan. Note that all my tests passed, and that the CI is
green. The buildfarm will quickly tell if this needs more adjustments.

Author: Michael Paquier, Juan José Santamaría Flecha
Reviewed-by: Thomas Munro
Discussion: https://postgr.es/m/Yo7tHKD8VCkeNi71@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/495ed0ef2d72a6a74def296e042022479d5d07bd

Modified Files
--------------
doc/src/sgml/install-windows.sgml | 9 ++-------
doc/src/sgml/installation.sgml | 9 ++++-----
src/backend/main/main.c | 17 -----------------
src/backend/utils/adt/pg_locale.c | 4 ++--
src/bin/pg_ctl/pg_ctl.c | 26 ++------------------------
src/include/port/win32.h | 17 +++--------------
6 files changed, 13 insertions(+), 69 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-07-07 06:51:19 pgsql: Convert macros to static inline functions (block.h)
Previous Message Amit Kapila 2022-07-07 04:01:20 pgsql: Re-order disable_on_error in tab-complete.