pgsql: pgstat: drop subscription stats without slot as well, fix commen

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgstat: drop subscription stats without slot as well, fix commen
Date: 2022-07-06 16:28:07
Message-ID: E1o97sj-001VPA-P8@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgstat: drop subscription stats without slot as well, fix comment

There's no reason anymore to only drop subscription stats if associated with a
slot, now that stats drops are transactional. And since there's now no other
cleanup of stats, this would lead to stats for slot-less subscriptions to get
leaked (however most slot-less subs won't have stats).

Additionally, the comment referring to autovacuum cleaning up stats was
clearly outdated.

Author: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAD21AoAwiby3HeJE7vJe16Gr75RFfJ640dyHqvsiUhyKJTXPtw@mail.gmail.com
Backpatch: 15-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7b64e4b3fa04769b725306a75bf3dd26e5a854fa

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-07-06 17:10:47 pgsql: pg_stat_statements: Fix test that assumes wal_records = rows.
Previous Message Robert Haas 2022-07-06 15:56:20 pgsql: Change internal RelFileNode references to RelFileNumber or RelFi