From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz |
Date: | 2022-07-05 18:33:25 |
Message-ID: | E1o8nMR-001MJt-Kd@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR size.
The new expression step types increased the size of ExprEvalStep by ~4 for all
types of expression steps, slowing down expression evaluation noticeably. Move
them out of line.
There's other issues with these expression steps, but addressing them is
largely independent of this aspect.
Author: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-By: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://postgr.es/m/20220616233130.rparivafipt6doj3@alap3.anarazel.de
Backpatch: 15-
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/67b26703b4152a30a91208e28a4b72b3abda5832
Modified Files
--------------
src/backend/executor/execExpr.c | 93 +++++++++++++++-------------
src/backend/executor/execExprInterp.c | 104 ++++++++++++++++---------------
src/include/executor/execExpr.h | 111 +++++++++++++++++++---------------
src/tools/pgindent/typedefs.list | 2 +
4 files changed, 170 insertions(+), 140 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-07-05 20:36:37 | pgsql: pgstat: reduce timer overhead by leaving timer running. |
Previous Message | Andres Freund | 2022-07-05 18:17:33 | pgsql: Revert 019_replslot_limit.pl related debugging aids. |