From: | Etsuro Fujita <efujita(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Disable asynchronous execution if using gating Result nodes. |
Date: | 2022-04-28 06:27:12 |
Message-ID: | E1njxcN-001VEU-MV@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Disable asynchronous execution if using gating Result nodes.
mark_async_capable_plan(), which is called from create_append_plan() to
determine whether subplans are async-capable, failed to take into
account that the given subplan created from a given subpath might
include a gating Result node if the subpath is a SubqueryScanPath or
ForeignPath, causing a segmentation fault there when the subplan created
from a SubqueryScanPath includes the Result node, or causing
ExecAsyncRequest() to throw an error about an unrecognized node type
when the subplan created from a ForeignPath includes the Result node,
because in the latter case the Result node was unintentionally
considered as async-capable, but we don't currently support executing
Result nodes asynchronously. Fix by modifying mark_async_capable_plan()
to disable asynchronous execution in such cases. Also, adjust code in
the ProjectionPath case in mark_async_capable_plan(), for consistency
with other cases, and adjust/improve comments there.
is_async_capable_path() added in commit 27e1f1456, which was rewritten
to mark_async_capable_plan() in a later commit, has the same issue,
causing the error at execution mentioned above, so back-patch to v14
where the aforesaid commit went in.
Per report from Justin Pryzby.
Etsuro Fujita, reviewed by Zhihong Yu and Justin Pryzby.
Discussion: https://postgr.es/m/20220408124338.GK24419%40telsasoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5c854e7a2c8a6cd26040e0f9949e7a4a007f6366
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 66 ++++++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 13 +++++
src/backend/optimizer/plan/createplan.c | 34 ++++++++++---
3 files changed, 106 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Dilger | 2022-04-28 15:42:38 | Re: Unstable tests for recovery conflict handling |
Previous Message | Michael Paquier | 2022-04-28 04:08:50 | pgsql: Revert recent changes with durable_rename_excl() |