pgsql: Make JSON path numeric literals more correct

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make JSON path numeric literals more correct
Date: 2022-03-28 09:20:12
Message-ID: E1nYlXn-001jeX-Gx@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make JSON path numeric literals more correct

Per ECMAScript standard (ECMA-262, referenced by SQL standard), the
syntax forms

.1
1.

should be allowed for decimal numeric literals, but the existing
implementation rejected them.

Also, by the same standard, reject trailing junk after numeric
literals.

Note that the ECMAScript standard for numeric literals is in respects
like these slightly different from the JSON standard, which might be
the original cause for this discrepancy.

A change is that this kind of syntax is now rejected:

1.type()

This needs to be written as

(1).type()

This is correct; normal JavaScript also does not accept this syntax.

We also need to fix up the jsonpath output function for this case. We
put parentheses around numeric items if they are followed by another
path item.

Reviewed-by: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
Discussion: https://www.postgresql.org/message-id/flat/50a828cc-0a00-7791-7883-2ed06dfb2dbb(at)enterprisedb(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e26114c817b610424010cfbe91a743f591246ff1

Modified Files
--------------
src/backend/utils/adt/jsonpath.c | 4 +
src/backend/utils/adt/jsonpath_scan.l | 24 ++--
src/test/regress/expected/jsonpath.out | 238 +++++++++++++++++++++------------
src/test/regress/sql/jsonpath.sql | 8 ++
4 files changed, 176 insertions(+), 98 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2022-03-28 13:01:21 pgsql: Document autoanalyze limitations for partitioned tables
Previous Message Andres Freund 2022-03-28 05:37:01 pgsql: Don't fail for > 1 walsenders in 019_replslot_limit, add debug m