pgsql: test_decoding: Add comments about delaying BEGIN/PREPARE

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: test_decoding: Add comments about delaying BEGIN/PREPARE
Date: 2022-03-23 15:48:18
Message-ID: E1nX3De-0012XD-4G@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

test_decoding: Add comments about delaying BEGIN/PREPARE

It is not immediately obvious why we return early in these functions;
these comments should make it so.

Reviewed-by: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/202202141336.xv35beswc6ec@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dfdb2f3bf5c6ff4014de142a7b82b205224e01d3

Modified Files
--------------
contrib/test_decoding/test_decoding.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-23 15:48:40 Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding
Previous Message Robert Haas 2022-03-23 15:38:39 Re: pgsql: Unbreak the build.