pgsql: pg_basebackup: Avoid unclean failure with server-compression and

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_basebackup: Avoid unclean failure with server-compression and
Date: 2022-03-11 17:34:20
Message-ID: E1nSj9f-000IRR-Oa@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_basebackup: Avoid unclean failure with server-compression and -D -.

Fail with a suitable error message instead. We can't inject the backup
manifest into the output tarfile without decompressing it, and if
we did that, we'd have to recompress the tarfile afterwards to produce
the result the user is expecting. While we have enough infrastructure
in pg_basebackup now to accomplish that whole series of steps without
much additional code, it seems like excessively surprising behavior.
The user probably did not select server-side compression with the idea
that the client was going to end up decompressing it and then
recompressing.

Report from Justin Pryzby. Fix by me.

Discussion: http://postgr.es/m/CA+Tgmob6Rnjz-Qv32h3yJn8nnUkLhrtQDAS4y5AtsgtorAFHRA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2de45f9200d9adcac50015521574696dc464ccd

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-11 17:37:32 pgsql: pg_basebackup: Clean up some bogus file extension tests.
Previous Message Peter Eisentraut 2022-03-11 07:54:17 pgsql: DefineCollation() code cleanup