pgsql: Move scanint8() to numutils.c

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move scanint8() to numutils.c
Date: 2022-02-14 21:18:04
Message-ID: E1nJijU-0000fr-0S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Move scanint8() to numutils.c

Move scanint8() to numutils.c and rename to pg_strtoint64(). We
already have a "16" and "32" version of that, and the code inside the
functions was aligned, so this move makes all three versions
consistent. The API is also changed to no longer provide the errorOK
case. Users that need the error checking can use strtoi64().

Reviewed-by: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/b239564c-cad0-b23e-c57e-166d883cb97d(at)enterprisedb(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cfc7191dfea330dd7a71e940d59de78129bb6175

Modified Files
--------------
src/backend/parser/parse_node.c | 12 +++-
src/backend/replication/pgoutput/pgoutput.c | 10 ++--
src/backend/utils/adt/int8.c | 90 +----------------------------
src/backend/utils/adt/numutils.c | 84 +++++++++++++++++++++++++++
src/bin/pgbench/pgbench.c | 4 +-
src/include/utils/builtins.h | 1 +
src/include/utils/int8.h | 25 --------
7 files changed, 104 insertions(+), 122 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-02-14 21:22:33 Re: pgsql: Track LLVM 15 changes.
Previous Message Thomas Munro 2022-02-14 20:59:32 Re: pgsql: Track LLVM 15 changes.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-14 21:19:40 Re: [PATCH] Add tests for psql tab completion
Previous Message Andrew Dunstan 2022-02-14 21:02:37 Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates