pgsql: Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.
Date: 2021-10-28 15:45:35
Message-ID: E1mg7ax-0000Q7-2a@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.

Commits fdd965d07 and 3cd9c3b92 tested CREATE INDEX CONCURRENTLY by
launching two separate pgbench runs concurrently. This was needed so
that only a single client thread would run CREATE INDEX CONCURRENTLY,
avoiding deadlock between two CICs. However, there's a better way,
which is to use an advisory lock to prevent concurrent CICs. That's
better in part because the test code is shorter and more readable, but
mostly because it automatically scales things to launch an appropriate
number of CICs relative to the number of INSERT transactions.
As committed, typically half to three-quarters of the CIC transactions
were pointless because the INSERT transactions had already stopped.

In passing, remove background_pgbench, which was added to support
these tests and isn't needed anymore. We can always put it back
if we find a use for it later.

Back-patch to v12; older pgbench versions lack the
conditional-execution features needed for this method.

Tom Lane and Andrey Borodin

Discussion: https://postgr.es/m/139687.1635277318@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b1f943d2aa7eba9d7f0f11d3ba66c92f814cca78

Modified Files
--------------
contrib/amcheck/t/002_cic.pl | 48 +++++++++++++-----------------------
contrib/amcheck/t/003_cic_2pc.pl | 53 ++++++++++++++++++----------------------
src/test/perl/PostgresNode.pm | 48 ------------------------------------
3 files changed, 41 insertions(+), 108 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-10-28 17:40:03 pgsql: Speed up printing of integers in snprintf.c.
Previous Message Alvaro Herrera 2021-10-28 13:32:58 Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().