From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor LogicalTapeSet/LogicalTape interface. |
Date: | 2021-10-18 12:15:08 |
Message-ID: | E1mcRXo-0000e8-Vs@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor LogicalTapeSet/LogicalTape interface.
All the tape functions, like LogicalTapeRead and LogicalTapeWrite, now
take a LogicalTape as argument, instead of LogicalTapeSet+tape number.
You can create any number of LogicalTapes in a single LogicalTapeSet, and
you don't need to decide the number upfront, when you create the tape set.
This makes the tape management in hash agg spilling in nodeAgg.c simpler.
Discussion: https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi
Reviewed-by: Peter Geoghegan, Zhihong Yu, John Naylor
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c4649cce39a41b27db874e75ddd47adaec1b0ea4
Modified Files
--------------
src/backend/executor/nodeAgg.c | 187 ++++-----------
src/backend/utils/sort/logtape.c | 456 +++++++++++++++----------------------
src/backend/utils/sort/tuplesort.c | 229 +++++++++----------
src/include/nodes/execnodes.h | 3 +-
src/include/utils/logtape.h | 37 ++-
5 files changed, 359 insertions(+), 553 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2021-10-18 12:15:09 | pgsql: Replace polyphase merge algorithm with a simple balanced k-way m |
Previous Message | Amit Kapila | 2021-10-18 05:17:56 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |