pgsql: Provide error hint on exit() check when building libpq

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Provide error hint on exit() check when building libpq
Date: 2021-10-04 12:33:56
Message-ID: E1mXNAK-0004Ja-FP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Provide error hint on exit() check when building libpq

Commit dc227eb82 introduced a restriction on libpq that no functions which
invoke exit() are allowed to be called. This was further refined and fixed
in e45b0dfa1f and 2f7bae2f92 and 792259591. While this is well documented
in the Makefile, the error message emitted when the check failed was terse,
without hints for new developers without prior context. This adds an error
hint to assist new developers onboarding to postgres.

Author: Rachel Heaton <rheaton(at)vmware(dot)com>
Co-authored-by: Jacob Champion <pchampion(at)vmware(dot)com>
Discussion: https://postgr.es/m/CADJcwiVL20955HCNzDqz9BEDr6A77pz6-nac5sbZVvhAEMijLg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e9bc0441f1446f6614fa6712841acec91890e089

Modified Files
--------------
src/interfaces/libpq/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-04 13:14:18 pgsql: Fix duplicate words in comments
Previous Message Peter Eisentraut 2021-10-04 11:03:21 pgsql: Update Unicode map text files