pgsql: Document XLOG_INCLUDE_XID a little better

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Document XLOG_INCLUDE_XID a little better
Date: 2021-09-21 22:48:33
Message-ID: E1mSoYz-0007Fh-D9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Document XLOG_INCLUDE_XID a little better

I noticed that commit 0bead9af484c left this flag undocumented in
XLogSetRecordFlags, which led me to discover that the flag doesn't
actually do what the one comment on it said it does. Improve the
situation by adding some more comments.

Backpatch to 14, where the aforementioned commit appears.

Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/202109212119.c3nhfp64t2ql@alvherre.pgsql

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c1d1ae1db23796e4d1b04f5c087944722cf1446a

Modified Files
--------------
src/backend/access/transam/xloginsert.c | 2 ++
src/include/access/xlog.h | 2 +-
src/include/access/xlogrecord.h | 5 +++--
3 files changed, 6 insertions(+), 3 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-09-21 23:07:13 pgsql: Fix misevaluation of STABLE parameters in CALL within plpgsql.
Previous Message noreply 2021-09-21 22:03:03 pgsql: Tag refs/tags/REL_14_RC1 was created

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-09-21 22:58:05 Re: windows build slow due to windows.h includes
Previous Message Jan Wieck 2021-09-21 22:47:02 Re: PostgreSQL High Precision Support Extension.