pgsql: Cache the results of format_type() queries in pg_dump.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Cache the results of format_type() queries in pg_dump.
Date: 2021-08-31 17:54:12
Message-ID: E1mL7xc-0004AP-Fb@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cache the results of format_type() queries in pg_dump.

There's long been a "TODO: there might be some value in caching
the results" annotation on pg_dump's getFormattedTypeName function;
but we hadn't gotten around to checking what it was costing us to
repetitively look up type names. It turns out that when dumping the
current regression database, about 10% of the total number of queries
issued are duplicative format_type() queries. However, Hubert Depesz
Lubaczewski reported a not-unusual case where these account for over
half of the queries issued by pg_dump. Individually these queries
aren't expensive, but when network lag is a factor, they add up to a
problem. We can very easily add some caching to getFormattedTypeName
to solve it.

Since this is such a simple fix and can have a visible performance
benefit, back-patch to all supported branches.

Discussion: https://postgr.es/m/20210826084430.GA26282@depesz.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9407dbbcb5b587cbefc4af14d1612b49abcb143b

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 13 +++++++++++--
src/bin/pg_dump/pg_dump.h | 6 ++++--
2 files changed, 15 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-08-31 19:04:28 pgsql: In pg_dump, avoid doing per-table queries for RLS policies.
Previous Message Tomas Vondra 2021-08-31 17:46:20 pgsql: Rename the role in stats_ext to have regress_ prefix