| From: | David Rowley <drowley(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Robustify tuplesort's free_sort_tuple function |
| Date: | 2021-07-13 01:32:34 |
| Message-ID: | E1m37Hm-0006z8-Uw@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Robustify tuplesort's free_sort_tuple function
41469253e went to the trouble of removing a theoretical bug from
free_sort_tuple by checking if the tuple was NULL before freeing it. Let's
make this a little more robust by also setting the tuple to NULL so that
should we be called again we won't end up doing a pfree on the already
pfree'd tuple. Per advice from Tom Lane.
Discussion: https://postgr.es/m/3188192.1626136953@sss.pgh.pa.us
Backpatch-through: 9.6, same as 41469253e
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d0e44bae4923cebe08fd03f8ac6cb42757eec480
Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 1 +
1 file changed, 1 insertion(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-13 01:57:18 | pgsql: Remove useless range checks on INT8 sequences |
| Previous Message | David Rowley | 2021-07-13 01:31:55 | pgsql: Robustify tuplesort's free_sort_tuple function |