pgsql: Fix pgbench timestamp bugs.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pgbench timestamp bugs.
Date: 2021-07-11 08:14:31
Message-ID: E1m2Ubf-00071S-7I@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pgbench timestamp bugs.

Commit 547f04e changed pgbench to use microsecond accounting, but
introduced a couple of logging and aggregation bugs:

1. We print Unix epoch timestamps so that you can correlate them with
other logs, but these were inadvertently changed to use a
system-dependent reference epoch. Compute Unix timestamps, and begin
aggregation intervals on the boundaries of whole Unix epoch seconds, as
before.

2. The user-supplied aggregation interval needed to be scaled.

Back-patch to 14.

Author: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Author: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Author: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Reported-by: YoungHwan Joo <rulyox(at)gmail(dot)com>
Reported-by: Gregory Smith <gregsmithpgsql(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAF7igB1r6wRfSCEAB-iZBKxkowWY6%2BdFF2jObSdd9%2BiVK%2BvHJg%40mail.gmail.com
Discussion: https://postgr.es/m/CAHLJuCW_8Vpcr0%3Dt6O_gozrg3wXXWXZXDioYJd3NhvKriqgpfQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0e39a608ed5545cc6b9d538ac937c3c1ee8cdc36

Modified Files
--------------
src/bin/pgbench/pgbench.c | 43 ++++++++++++++++++++++++++++++++++---------
1 file changed, 34 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2021-07-11 08:14:50 pgsql: Fix pgbench timestamp bugs.
Previous Message Dean Rasheed 2021-07-10 18:19:12 Re: pgsql: Fix numeric_mul() overflow due to too many digits after decimal