pgsql: Fix build failure with newer ICU

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix build failure with newer ICU
Date: 2021-07-01 08:58:27
Message-ID: E1lysWh-0007eN-3m@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix build failure with newer ICU

ICU 69 causes compile failures with PostgreSQL 10. ICU 69 has
switched to using stdbool.h, which conflicts with the home-made
definitions that we used until PostgreSQL 10. Newer PostgreSQL major
versions are therefore not affected. (Older PostgreSQL versions don't
have ICU support.)

The workaround is to undefine "bool" after including ICU headers,
similar to the solution already in place for plperl for the same
underlying reasons.

Discussion: https://www.postgresql.org/message-id/flat/28588e5a-c204-0361-01f1-a1ee1b590233%40enterprisedb.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e7be25039e4923a3a28a708d0cc141136e80546e

Modified Files
--------------
src/backend/utils/adt/formatting.c | 4 ++++
src/backend/utils/adt/pg_locale.c | 4 ++++
src/include/utils/pg_locale.h | 4 ++++
3 files changed, 12 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-07-01 12:45:18 pgsql: Allow specifying pg_waldump --rmgr option multiple times.
Previous Message Peter Eisentraut 2021-07-01 07:34:20 pgsql: Add tests for UNBOUNDED syntax ambiguity