pgsql: Fixes in ALTER SUBSCRIPTION DROP PUBLICATION code

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fixes in ALTER SUBSCRIPTION DROP PUBLICATION code
Date: 2021-06-25 07:59:05
Message-ID: E1lwgjx-0000kU-1P@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fixes in ALTER SUBSCRIPTION DROP PUBLICATION code

ALTER SUBSCRIPTION DROP PUBLICATION does not actually support
copy_data option, so remove it from tab completion.

Also, reword the error message that is thrown when all the
publications from a subscription are specified to be dropped.

Also, made few doc and cosmetic adjustments.

Author: Vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: Bharath Rupireddy <bharath(dot)rupireddy(at)enterprisedb(dot)com>
Reviewed-by: Japin Li <japinli(at)hotmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CALDaNm21RwsDzs4xj14ApteAF7auyyomHNnp+NEL-sH8m-jMvQ(at)mail(dot)gmail(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e59d428f34297cd0eb67e3b4e4b8c8bc58504921

Modified Files
--------------
doc/src/sgml/ref/alter_subscription.sgml | 19 ++++++++++---------
src/backend/commands/subscriptioncmds.c | 6 +++---
src/bin/psql/tab-complete.c | 8 ++++++--
src/test/regress/expected/subscription.out | 2 +-
4 files changed, 20 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-06-25 09:40:36 pgsql: Put option listing back into alphabetical order
Previous Message Peter Eisentraut 2021-06-25 06:15:37 pgsql: doc: Change reloption data type spelling for consistency