pgsql: In PostgresNode.pm, don't pass SQL to psql on the command line

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: In PostgresNode.pm, don't pass SQL to psql on the command line
Date: 2021-06-03 20:15:11
Message-ID: E1lotkF-0001o5-QP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In PostgresNode.pm, don't pass SQL to psql on the command line

The Msys shell mangles certain patterns in its command line, so avoid
handing arbitrary SQL to psql on the command line and instead use
IPC::Run's redirection facility for stdin. This pattern is already
mostly whats used, but query_poll_until() was not doing the right thing.

Problem discovered on the buildfarm when a new TAP test failed on msys.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/11e9caff82bc7326e2bc9782937cb03875050cc4

Modified Files
--------------
src/test/perl/PostgresNode.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2021-06-03 20:41:53 Re: pgsql: Add regression test for recovery pause.
Previous Message Tom Lane 2021-06-03 18:54:27 pgsql: Fix incorrect permissions on pg_subscription.