pgsql: Add missing NULL check when building Result Cache paths

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing NULL check when building Result Cache paths
Date: 2021-05-24 00:37:46
Message-ID: E1lkybK-0003zy-Tx@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing NULL check when building Result Cache paths

Code added in 9e215378d to disable building of Result Cache paths when
not all join conditions are part of the parameterization of a unique
join failed to first check if the inner path's param_info was set before
checking the param_info's ppi_clauses.

Add a check for NULL values here and just bail on trying to build the
path if param_info is NULL. lateral_vars are not considered when
deciding if the join is unique, so we're not missing out on doing the
optimization when there are lateral_vars and no param_info.

Reported-by: Coverity, via Tom Lane
Discussion: https://postgr.es/m/457998.1621779290@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/99c5852e20a0987eca1c38ba0c09329d4076b6a0

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-05-24 22:03:54 pgsql: Doc: move some catalogs.sgml entries to the right place.
Previous Message David Rowley 2021-05-24 00:08:35 Re: pgsql: Fix planner's use of Result Cache with unique joins