pgsql: Avoid creating testtablespace directories where not wanted.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid creating testtablespace directories where not wanted.
Date: 2021-05-19 18:04:23
Message-ID: E1ljQYR-0003Le-HI@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid creating testtablespace directories where not wanted.

Recently we refactored things so that pg_regress makes the
"testtablespace" subdirectory used by the core regression tests,
instead of doing that in the makefiles. That had the undesirable
side effect of making such a subdirectory in every directory that
has "input" or "output" test files. Since these subdirectories
remain empty, git doesn't complain about them, but nonetheless
they're clutter.

To fix, invent an explicit --make-testtablespace-dir switch,
so that pg_regress only makes the subdirectory when explicitly
told to.

Discussion: https://postgr.es/m/2854388.1621284789@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/413c1ef98e0c9c708c4a9a13a838a55b65b16a80

Modified Files
--------------
src/test/regress/GNUmakefile | 3 ++-
src/test/regress/pg_regress.c | 53 +++++++++++++++++++++++++++++--------------
src/tools/msvc/vcregress.pl | 2 ++
3 files changed, 40 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2021-05-20 12:08:42 pgsql: Use a more portable way to get the version string in PostgresNod
Previous Message Bruce Momjian 2021-05-19 15:22:31 pgsql: doc: revert 1e7d53bd01 so libpq chapter number is accessable