pgsql: Improve slightly misleading comments in nodeFuncs.c

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve slightly misleading comments in nodeFuncs.c
Date: 2021-04-10 07:20:13
Message-ID: E1lV7uf-0007Z0-NP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve slightly misleading comments in nodeFuncs.c

There were some comments in nodeFuncs.c that, depending on your
interpretation of the word "result", could lead you to believe that the
comments were badly copied and pasted from somewhere else. If you thought
of "result" as the return value of the function that the comment is
written in, then you'd be misled. However, if you'd correctly
interpreted "result" to mean the result type of the given node type,
you'd not have seen any issues.

Here we do a small cleanup to try to prevent any future
misinterpretations. Per wording suggestion from Tom Lane.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/CAApHDvp+Bw=2Qiu5=uXMKfC7gd0+B=4JvexVgGJU=am2g9a1CA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/152d33bccec7176f50be225bdbedf2e6de214e54

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 69 +++++++++++++++++++++++++++----------------
1 file changed, 44 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-04-10 16:08:34 pgsql: Doc: update documentation of check_function_bodies.
Previous Message Noah Misch 2021-04-10 03:07:10 Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres