pgsql: Suppress length of Notice/Error msgs in PQtrace regress mode

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Suppress length of Notice/Error msgs in PQtrace regress mode
Date: 2021-04-09 21:15:29
Message-ID: E1lUyTR-0003cE-Ii@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Suppress length of Notice/Error msgs in PQtrace regress mode

A (relatively minor) annoyance of ErrorResponse/NoticeResponse messages
as printed by PQtrace() is that their length might vary when we move
error messages from one source file to another, one function to another,
or even when their location line numbers change number of digits.

To avoid having to adjust expected files for some tests, make the
regress mode of PQtrace() suppress the length word of NoticeResponse and
ErrorResponse messages.

Discussion: https://postgr.es/m/20210402023010.GA13563@alvherre.pgsql
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e7e341409a3d85aba4cf754ba9cf722a4d8e6676

Modified Files
--------------
src/interfaces/libpq/fe-trace.c | 11 ++++++++++-
src/test/modules/libpq_pipeline/traces/pipeline_abort.trace | 8 ++++----
src/test/modules/libpq_pipeline/traces/transaction.trace | 6 +++---
3 files changed, 17 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-04-09 21:31:55 Re: pgsql: autovacuum: handle analyze for partitioned tables
Previous Message Thomas Munro 2021-04-09 20:43:49 pgsql: Make new GUC short descriptions more consistent.