pgsql: Set pg_class.reltuples for partitioned tables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Set pg_class.reltuples for partitioned tables
Date: 2021-04-09 15:53:45
Message-ID: E1lUtS5-0001kd-2z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Set pg_class.reltuples for partitioned tables

When commit 0827e8af70f4 added auto-analyze support for partitioned
tables, it included code to obtain reltuples for the partitioned table
as a number of catalog accesses to read pg_class.reltuples for each
partition. That's not only very inefficient, but also problematic
because autovacuum doesn't hold any locks on any of those tables -- and
doesn't want to. Replace that code with a read of pg_class.reltuples
for the partitioned table, and make sure ANALYZE and TRUNCATE properly
maintain that value.

I found no code that would be affected by the change of relpages from
zero to non-zero for partitioned tables, and no other code that should
be maintaining it, but if there is, hopefully it'll be an easy fix.

Per buildfarm.

Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: Zhihong Yu <zyu(at)yugabyte(dot)com>
Discussion: https://postgr.es/m/1823909.1617862590@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0e69f705cc1a3df273b38c9883fb5765991e04fe

Modified Files
--------------
src/backend/commands/analyze.c | 12 ++++++++++
src/backend/commands/tablecmds.c | 47 ++++++++++++++++++++++++++++++++++++-
src/backend/postmaster/autovacuum.c | 39 +-----------------------------
3 files changed, 59 insertions(+), 39 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-04-09 15:54:30 Re: pgsql: autovacuum: handle analyze for partitioned tables
Previous Message Tom Lane 2021-04-09 11:53:45 Re: pgsql: autovacuum: handle analyze for partitioned tables