| From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix BRIN minmax-multi distance for inet type |
| Date: | 2021-04-04 17:25:09 |
| Message-ID: | E1lT6Un-0003zU-K1@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix BRIN minmax-multi distance for inet type
The distance calculation ignored the mask, unlike the inet comparator,
which resulted in negative distance in some cases. Fixed by applying the
mask in brin_minmax_multi_distance_inet. I've considered simply calling
inetmi() to calculate the delta, but that does not consider mask either.
Reviewed-by: Zhihong Yu
Discussion: https://postgr.es/m/1a0a7b9d-9bda-e3a2-7fa4-88f15042a051%40enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e1fbe1181c86247eaf8b4b142b81361ce4efcc66
Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 59 +++++++++++++++++++++++++----
1 file changed, 51 insertions(+), 8 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-04-04 17:26:38 | pgsql: Fix order of parameters in BRIN minmax-multi calls |
| Previous Message | Tomas Vondra | 2021-04-04 17:23:23 | pgsql: Fix BRIN minmax-multi distance for timetz type |