pgsql: Improve psql's behavior when the editor is exited without saving

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve psql's behavior when the editor is exited without saving
Date: 2021-04-03 21:38:39
Message-ID: E1lSnyZ-0005jP-1j@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve psql's behavior when the editor is exited without saving.

When editing the previous query buffer, if the editor is exited
without modifying the temp file then clear the query buffer,
rather than re-loading (and probably re-executing) the previous
query buffer. This reduces the probability of accidentally
re-executing something you didn't intend to.

Similarly, in "\e file", if the file isn't actually modified
then don't load it into the query buffer. And in "\ef" and
"\ev", if no changes are made then clear the query buffer
instead of loading the function or view definition into it.

Cases where we fail to invoke the editor at all, or it returns
a nonzero status, are treated like the no-file-modification case.

Laurenz Albe, reviewed by Jacob Champion

Discussion: https://postgr.es/m/0ba3f2a658bac6546d9934ab6ba63a805d46a49b.camel@cybertec.at

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55873a00e3c3349664e7215077dca74ccea08b4d

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 10 ++++--
src/bin/psql/command.c | 74 +++++++++++++++++++++++++++++++++---------
2 files changed, 66 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2021-04-04 17:21:28 pgsql: Fix BRIN minmax-multi distance for interval type
Previous Message Andres Freund 2021-04-03 19:08:19 pgsql: Improve efficiency of wait event reporting, remove proc.h depend