From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve stability of test with vacuum_truncate in reloptions.sql |
Date: | 2021-04-02 00:46:12 |
Message-ID: | E1lS7wy-0005ix-0S@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve stability of test with vacuum_truncate in reloptions.sql
This test has been using a simple VACUUM with pg_relation_size() to
check if a relation gets physically truncated or not, but forgot the
fact that some concurrent activity, like checkpoint buffer writes, could
cause some pages to be skipped. The second test enabling
vacuum_truncate could fail, seeing a non-empty relation. The first test
would not have failed, but could finish by testing a behavior different
than the one aimed for. Both tests gain a FREEZE option, to make the
vacuums more aggressive and prevent page skips.
This is similar to the issues fixed in c2dc1a7.
Author: Arseny Sher
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/87tuotr2hh.fsf@ars-thinkpad
backpatch-through: 12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/89937d001294b39469790e5a583e438af2ca1235
Modified Files
--------------
src/test/regress/expected/reloptions.out | 6 ++++--
src/test/regress/sql/reloptions.sql | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2021-04-02 01:11:35 | pgsql: Add Result Cache executor node (take 2) |
Previous Message | Tom Lane | 2021-04-01 21:55:26 | pgsql: Rethink handling of pass-by-value leaf datums in SP-GiST. |