From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Update the names of Parallel Hash Join phases. |
Date: | 2021-03-17 05:47:57 |
Message-ID: | E1lMP2D-0002EG-Ij@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Update the names of Parallel Hash Join phases.
Commit 3048898e dropped -ING from some wait event names that correspond
to barrier phases. Update the phases' names to match.
While we're here making cosmetic changes, also rename "DONE" to "FREE".
That pairs better with "ALLOCATE", and describes the activity that
actually happens in that phase (as we do for the other phases) rather
than describing a state. The distinction is clearer after bugfix commit
3b8981b6 split the phase into two. As for the growth barriers, rename
their "ALLOCATE" phase to "REALLOCATE", which is probably a better
description of what happens then. Also improve the comments about
the phases a bit.
Discussion: https://postgr.es/m/CA%2BhUKG%2BMDpwF2Eo2LAvzd%3DpOh81wUTsrwU1uAwR-v6OGBB6%2B7g%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/378802e3713c6c0fce31d2390c134cd5d7c30157
Modified Files
--------------
src/backend/executor/nodeHash.c | 72 ++++++++++++++++----------------
src/backend/executor/nodeHashjoin.c | 83 +++++++++++++++++++------------------
src/backend/postmaster/pgstat.c | 8 ++--
src/include/executor/hashjoin.h | 38 ++++++++---------
src/include/pgstat.h | 4 +-
5 files changed, 104 insertions(+), 101 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-03-17 07:24:47 | pgsql: Small error message improvement |
Previous Message | Thomas Munro | 2021-03-17 05:15:36 | pgsql: Fix race in Parallel Hash Join batch cleanup. |