pgsql: Improve logging of bad parameter values in BIND messages.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve logging of bad parameter values in BIND messages.
Date: 2021-03-16 15:16:51
Message-ID: E1lMBRD-0005Dm-CY@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve logging of bad parameter values in BIND messages.

Since commit ba79cb5dc, values of bind parameters have been logged
during errors in extended query mode. However, we only did that after
we'd collected and converted all the parameter values, thus failing to
offer any useful localization of invalid-parameter problems. Add a
separate callback that's used during parameter collection, and have it
print the parameter number, along with the input string if text input
format is used.

Justin Pryzby and Tom Lane

Discussion: https://postgr.es/m/20210104170939.GH9712@telsasoft.com
Discussion: https://postgr.es/m/CANfkH5k-6nNt-4cSv1vPB80nq2BZCzhFVR5O4VznYbsX0wZmow@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ea396362be1615e926ea69d666c770081a0d3ef

Modified Files
--------------
src/backend/tcop/postgres.c | 94 +++++++++++++++++++++++++++-
src/bin/pgbench/t/001_pgbench_with_server.pl | 16 +++++
2 files changed, 107 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2021-03-16 18:48:08 pgsql: Use pre-fetching for ANALYZE
Previous Message Alvaro Herrera 2021-03-16 14:36:06 Re: pgsql: Implement pipeline mode in libpq