pgsql: Fix nbtree page deletion error messages.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix nbtree page deletion error messages.
Date: 2021-03-02 21:03:48
Message-ID: E1lHCBI-0008IS-9y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix nbtree page deletion error messages.

Adjust some "can't happen" error messages that assumed that the page
deletion target page must be a half-dead page. This assumption was
wrong in the case of an internal target page. Simply refer to these
pages as the target page instead.

Internal pages are never marked half-dead. There is exactly one
half-dead page for each subtree undergoing deletion. The half-dead page
is also the target subtree's leaf-level page. This has been the case
since commit efada2b8, which totally overhauled nbtree page deletion.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3d8d5787a358156edaa7782f0c88e231af974a01

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-03-02 22:07:08 pgsql: nbtree page deletion: Add leaftopparent assertion.
Previous Message Tom Lane 2021-03-02 18:54:08 pgsql: Mark default_transaction_read_only as GUC_REPORT.