| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Default to wal_sync_method=fdatasync on FreeBSD. |
| Date: | 2021-02-15 03:23:04 |
| Message-ID: | E1lBUTY-0006pq-F3@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Default to wal_sync_method=fdatasync on FreeBSD.
FreeBSD 13 gained O_DSYNC, which would normally cause wal_sync_method to
choose open_datasync as its default value. That may not be a good
choice for all systems, and performs worse than fdatasync in some
scenarios. Let's preserve the existing default behavior for now.
Like commit 576477e73c4, which did the same for Linux, back-patch to all
supported releases.
Discussion: https://postgr.es/m/CA%2BhUKGLsAMXBQrCxCXoW-JsUYmdOL8ALYvaX%3DCrHqWxm-nWbGA%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f900a79ecdc1864a6ead72c97c34a41012227eaf
Modified Files
--------------
doc/src/sgml/config.sgml | 2 +-
src/backend/utils/misc/postgresql.conf.sample | 2 +-
src/include/port/freebsd.h | 9 +++++++++
3 files changed, 11 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-02-15 03:23:15 | pgsql: Default to wal_sync_method=fdatasync on FreeBSD. |
| Previous Message | Thomas Munro | 2021-02-15 02:24:14 | pgsql: Use pg_pwrite() in pg_test_fsync. |