pgsql: Remove [Merge]AppendPath.partitioned_rels.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove [Merge]AppendPath.partitioned_rels.
Date: 2021-02-01 19:44:20
Message-ID: E1l6f7U-0002it-0g@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove [Merge]AppendPath.partitioned_rels.

It turns out that the calculation of [Merge]AppendPath.partitioned_rels
in allpaths.c is faulty and sometimes omits relevant non-leaf partitions,
allowing an assertion added by commit a929e17e5a8 to trigger. Rather
than fix that, it seems better to get rid of those fields altogether.
We don't really need the info until create_plan time, and calculating
it once for the selected plan should be cheaper than calculating it
for each append path we consider.

The preceding two commits did away with all use of the partitioned_rels
values; this commit just mechanically removes the fields and the code
that calculated them.

Discussion: https://postgr.es/m/87sg8tqhsl.fsf@aurora.ydns.eu
Discussion: https://postgr.es/m/CAJKUy5gCXDSmFs2c=R+VGgn7FiYcLCsEFEuDNNLGfoha=pBE_g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f003a7522bfa11177dc52c65eb97273a1057dfba

Modified Files
--------------
src/backend/nodes/outfuncs.c | 2 -
src/backend/optimizer/path/allpaths.c | 181 ++++----------------------------
src/backend/optimizer/path/joinrels.c | 2 +-
src/backend/optimizer/plan/createplan.c | 2 -
src/backend/optimizer/plan/planner.c | 3 +-
src/backend/optimizer/prep/prepunion.c | 6 +-
src/backend/optimizer/util/pathnode.c | 8 +-
src/backend/partitioning/partprune.c | 2 +-
src/include/nodes/pathnodes.h | 6 --
src/include/optimizer/pathnode.h | 5 +-
src/include/partitioning/partprune.h | 1 -
11 files changed, 31 insertions(+), 187 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-02-01 21:39:21 pgsql: Doc: work a little harder on the initial examples for regex matc
Previous Message Tom Lane 2021-02-01 19:44:19 pgsql: Revise make_partition_pruneinfo to not use its partitioned_rels