pgsql: Avoid pushing quals down into sub-queries that have grouping set

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid pushing quals down into sub-queries that have grouping set
Date: 2020-08-22 18:47:07
Message-ID: E1k9YXj-0003qE-B5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid pushing quals down into sub-queries that have grouping sets.

The trouble with doing this is that an apparently-constant subquery
output column isn't really constant if it is a grouping column that
appears in only some of the grouping sets. A qual using such a
column would be subject to incorrect const-folding after push-down,
as seen in bug #16585 from Paul Sivash.

To fix, just disable qual pushdown altogether if the sub-query has
nonempty groupingSets. While we could imagine far less restrictive
solutions, there is not much point in working harder right now,
because subquery_planner() won't move HAVING clauses to WHERE within
such a subquery. If the qual stays in HAVING it's not going to be
a lot more useful than if we'd kept it at the outer level.

Having said that, this restriction could be removed if we used a
parsetree representation that distinguished such outputs from actual
constants, which is something I hope to do in future. Hence, make
the patch a minimal addition rather than integrating it more tightly
(e.g. by renumbering the existing items in subquery_is_pushdown_safe's
comment).

Back-patch to 9.5 where grouping sets were introduced.

Discussion: https://postgr.es/m/16585-9d8c340d23ade8c1@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/de627adaad3a161b3ae0cafeb76c20519845799b

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 15 ++++++++++++++
src/test/regress/expected/groupingsets.out | 32 ++++++++++++++++++++++++++++++
src/test/regress/sql/groupingsets.sql | 16 +++++++++++++++
3 files changed, 63 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2020-08-24 03:06:54 pgsql: Improve the vacuum error context phase information.
Previous Message Tom Lane 2020-08-22 16:34:27 pgsql: Fix ALTER TABLE's scheduling rules for AT_AddConstraint subcomma