pgsql: Fix timestamp range handling in regression tests of modules/comm

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix timestamp range handling in regression tests of modules/comm
Date: 2020-07-13 01:57:13
Message-ID: E1juniT-0002HW-P1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix timestamp range handling in regression tests of modules/commit_ts/

Switching the regression tests to use tstzrange() has proved to not be a
good idea for environments where the timestamp precision is low, as
internal range checks exclude the upper bound. So, if the commit
timestamp of a transaction matched with now() from the next query,
the test would fail. This changes to use two bound checks instead of
the range function, where the upper bound is inclusive.

Per buildfarm member jacana.

Discussion: https://postgr.es/m/20200712122507.GD21680@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5bfe6a3c485d3259f59fa2d2e1d34dea1a3baeba

Modified Files
--------------
.../commit_ts/expected/commit_timestamp.out | 49 ++++++++++++----------
.../commit_ts/expected/commit_timestamp_1.out | 19 ++++++---
.../modules/commit_ts/sql/commit_timestamp.sql | 19 ++++++---
3 files changed, 54 insertions(+), 33 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2020-07-13 03:32:08 pgsql: Revert "Track statistics for spilling of changes from ReorderBuf
Previous Message Michael Paquier 2020-07-13 01:53:04 Re: pgsql: Include replication origins in SQL functions for commit timestam