From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Rename field "relkind" to "objtype" for CTAS and ALTER TABLE nod |
Date: | 2020-07-11 04:33:50 |
Message-ID: | E1ju7Cw-0002dh-Rp@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Rename field "relkind" to "objtype" for CTAS and ALTER TABLE nodes
"relkind" normally refers to the char field from pg_class. However, in
the parse nodes AlterTableStmt and CreateTableAsStmt, "relkind" was used
for a field of type enum ObjectType, that could refer to other object
types than those possible for a relkind. Such fields being usually
named "objtype", switch the name in both structures to make things more
consistent. Note that this led to some confusion in functions that
also operate on a RangeTableEntry object, which also has a field named
"relkind".
This naming goes back to commit 09d4e96, where only OBJECT_TABLE and
OBJECT_INDEX were used. This got extended later to use as well
OBJECT_TYPE with e440e12, not really a relation kind.
Author: Mark Dilger
Reviewed-by: Daniel Gustafsson, Álvaro Herrera, Michael Paquier
Discussion: https://postgr.es/m/609181AE-E399-47C7-9221-856E0F96BF93@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cc35d8933a211d9965eb1c1d2749a903d5735db2
Modified Files
--------------
src/backend/commands/tablecmds.c | 4 ++--
src/backend/nodes/copyfuncs.c | 4 ++--
src/backend/nodes/equalfuncs.c | 4 ++--
src/backend/parser/analyze.c | 4 ++--
src/backend/parser/gram.y | 44 +++++++++++++++++++-------------------
src/backend/parser/parse_utilcmd.c | 6 +++---
src/backend/tcop/utility.c | 4 ++--
src/include/nodes/parsenodes.h | 4 ++--
8 files changed, 37 insertions(+), 37 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2020-07-11 11:51:47 | pgsql: doc: Add link from pg_dump --encoding to supported encodings |
Previous Message | Alexander Korotkov | 2020-07-11 00:25:40 | pgsql: Improve error reporting for jsonpath .double() method |