pgsql: Rework EXPLAIN format for incremental sort

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rework EXPLAIN format for incremental sort
Date: 2020-05-12 18:17:01
Message-ID: E1jYZSf-0003EM-0n@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rework EXPLAIN format for incremental sort

The explain format used by incremental sort was somewhat inconsistent
with other nodes, making it harder to parse and understand. This commit
addresses that by

- adding an extra space to better separate groups of values

- using colons instead of equal signs to separate key/value

- properly capitalizing first letter of a key

- using separate lines for full and pre-sorted groups

These changes were proposed by Justin Pryzby and mostly copy the final
explain format used to report WAL usage.

Author: Justin Pryzby
Reviewed-by: James Coleman
Discussion: https://postgr.es/m/20200419023625.GP26953@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6a918c3ac8a6b1d8b53cead6fcb7cbd84eee5750

Modified Files
--------------
src/backend/commands/explain.c | 21 +++++++++------------
src/test/regress/expected/incremental_sort.out | 21 +++++++++++----------
src/test/regress/sql/incremental_sort.sql | 4 ++--
3 files changed, 22 insertions(+), 24 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2020-05-12 20:08:27 pgsql: Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS
Previous Message Alvaro Herrera 2020-05-12 18:09:58 Re: pgsql: Show opclass and opfamily related information in psql