pgsql: Remove logical_read_local_xlog_page

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove logical_read_local_xlog_page
Date: 2020-03-17 21:22:06
Message-ID: E1jEJf4-0001af-Ci@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove logical_read_local_xlog_page

It devolved into a content-less wrapper over read_local_xlog_page, with
nothing to add, plus it's easily confused with walsender's
logical_read_xlog_page. There doesn't seem to be any reason for it to
stay.

src/include/replication/logicalfuncs.h becomes empty, so remove it too.
The prototypes it initially had were absorbed by generated fmgrprotos.h.

Discussion: https://postgr.es/m/20191115214102.GA15616@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5d0c2d5eba6b58b3c9955ee41c917f7df8b62746

Modified Files
--------------
src/backend/replication/logical/logicalfuncs.c | 11 +----------
src/backend/replication/slotfuncs.c | 6 +++---
src/backend/replication/walsender.c | 3 +--
src/include/replication/logicalfuncs.h | 19 -------------------
4 files changed, 5 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-17 22:29:29 pgsql: Adjust handling of an ANYARRAY actual input for an ANYARRAY argu
Previous Message Sergei Kornilov 2020-03-17 20:39:11 Re: pgsql: walreceiver uses a temporary replication slot by default