| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove overzealous _bt_split() assertions. |
| Date: | 2020-03-03 05:40:50 |
| Message-ID: | E1j90IU-0005x4-Qx@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove overzealous _bt_split() assertions.
_bt_split() is passed NULL as its insertion scankey for internal page
splits. Two recently added Assert() statements failed to consider this,
leading to a crash with pg_upgrade'd BREE_VERSION < 4 indexes. Remove
the assertions.
The assertions in question were added by commit 0d861bbb, which added
nbtree deduplication. It would be possible to fix the assertions
directly instead, but they weren't adding much anyway.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1e07f5e0a1cf56f8cbc121dbb86c128a0f711c94
Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 2 --
1 file changed, 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-03-03 06:02:28 | pgsql: Fix typo in monitoring.sgml. |
| Previous Message | Michael Paquier | 2020-03-03 04:57:34 | pgsql: Fix assertion failure with ALTER TABLE ATTACH PARTITION and inde |