pgsql: Make vacuum buffer counters 64 bits wide

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make vacuum buffer counters 64 bits wide
Date: 2020-02-05 20:15:34
Message-ID: E1izR5C-0004r8-3e@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make vacuum buffer counters 64 bits wide

Using 32 bit counters means they can now realistically wrap around when
vacuuming extremely large tables. Because they're signed integers,
stats printed by vacuum look very odd when they do.

We'd love to backpatch this, but refrain because the variables are
exported and could cause third-party code to break.

Reviewed-by: Julien Rouhaud, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20200131205926.GA16367@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/15d13e82911f7cc9f04f0bf419a96fd827fd1a9d

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 8 ++++----
src/backend/utils/init/globals.c | 6 +++---
src/include/miscadmin.h | 6 +++---
3 files changed, 10 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2020-02-05 20:24:44 pgsql: Force tuple conversion when the source has missing attributes.
Previous Message Alvaro Herrera 2020-02-05 18:07:36 pgsql: ALTER SUBSCRIPTION / REFRESH docs: explain copy_data