From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Further fixes for tab-completion TAP tests. |
Date: | 2020-01-03 17:54:19 |
Message-ID: | E1inR9P-0004gi-A9@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further fixes for tab-completion TAP tests.
Escape non-printable characters in failure reports, by using Data::Dumper
in Useqq mode. Also, bump $Test::Builder::Level so the diagnostic
references the calling line, and use diag() instad of note(),
so it shows even in non-verbose mode (per request from Christoph Berg).
Also, give up on trying to test for the specific way that readline
chooses to overwrite existing text in the \DRD -> \drds test.
There are too many variants, it seems, at least on the libedit
side of things.
Dagfinn Ilmari Mannsåker and Tom Lane
Discussion: https://postgr.es/m/20200103110128.GA28967@msg.df7cb.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/56a3921a2f5102f804bd0ff741e144a0e6f1c0b6
Modified Files
--------------
src/bin/psql/t/010_tab_completion.pl | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-03 17:55:23 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Previous Message | Christoph Berg | 2020-01-03 17:48:39 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |