| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove ATPrepSetStatistics |
| Date: | 2019-12-11 08:17:03 |
| Message-ID: | E1iexB9-0006Yx-7p@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove ATPrepSetStatistics
It was once possible to do ALTER TABLE ... SET STATISTICS on system
tables without allow_sytem_table_mods. This was changed apparently by
accident between PostgreSQL 9.1 and 9.2, but a code comment still
claimed this was possible. Without that functionality, having a
separate ATPrepSetStatistics() is useless, so use the generic
ATSimplePermissions() instead and move the remaining custom code into
ATExecSetStatistics().
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/cc8d2648-a0ec-7a86-13e5-db473484e19e%402ndquadrant.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/105eb360f2513523d221302b2d52880a14afae34
Modified Files
--------------
src/backend/commands/tablecmds.c | 53 +++++++++-------------------------------
1 file changed, 12 insertions(+), 41 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-12-11 15:54:13 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |
| Previous Message | Drouvot, Bertrand | 2019-12-11 08:17:01 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |