From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve stability of tests for VACUUM (SKIP_LOCKED) |
Date: | 2019-11-16 06:24:21 |
Message-ID: | E1iVrVN-0003vE-Iu@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve stability of tests for VACUUM (SKIP_LOCKED)
Concurrent autovacuums running with the main regression test suite
could cause the tests with VACUUM (SKIP_LOCKED) to generate randomly
WARNING messages. For these tests, set client_min_messages to ERROR to
get rid of those random failures, as disabling autovacuum for the
relations operated would not completely close the failure window.
For isolation tests, disable autovacuum for the relations vacuumed with
SKIP_LOCKED. The tests are designed so as LOCK commands are taken
in a first session before running a concurrent VACUUM (SKIP_LOCKED) in a
second to generate WARNING messages, but a concurrent autovacuum could
cause the tests to be slower.
Reported-by: Tom Lane
Author: Michael Paquier
Reviewed-by: Andres Freund, Tom Lane
Discussion: https://postgr.es/m/25294.1573077278@sss.pgh.pa.us
Backpatch-through: 12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3db0598d908f22435ab8138d1c76b971f17a5633
Modified Files
--------------
src/test/isolation/specs/vacuum-skip-locked.spec | 2 ++
src/test/regress/expected/vacuum.out | 5 ++++-
src/test/regress/sql/vacuum.sql | 5 ++++-
3 files changed, 10 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2019-11-16 18:09:19 | Re: pgsql: Add tests for tuplesort.c. |
Previous Message | Tomas Vondra | 2019-11-16 02:07:46 | pgsql: Properly determine length for on-disk TOAST values |